Open
Conversation
Member
|
@DaanHoogland is this in final state now? I wonder if we can pick this up now |
Member
Author
|
@borisstoyanov @vladimirpetrov this is a frame for the tests that can be used and has to be expanded to include all tests. It is a starting point not a finished product. |
Member
Author
|
@vladimirpetrov can you add comments and code ? |
DaanHoogland
commented
Sep 21, 2020
Comment on lines
+20
to
+21
| from marvin.lib.base import ServiceOffering, Configurations, VirtualMachine, Account, Volume, DiskOffering, StoragePool, \ | ||
| Role |
Member
Author
There was a problem hiding this comment.
I think there is a more need line for a multiline import in python (/me googling ...)
Suggested change
| from marvin.lib.base import ServiceOffering, Configurations, VirtualMachine, Account, Volume, DiskOffering, StoragePool, \ | |
| Role | |
| from marvin.lib.base import (ServiceOffering, | |
| Configurations, | |
| VirtualMachine, | |
| Account, | |
| Volume, | |
| DiskOffering, | |
| StoragePool, | |
| Role) |
| else: | ||
| print(">>> Current source datastore is the desired one - no need for setup") | ||
|
|
||
| # Migrate our volume to the target datastore |
Member
Author
There was a problem hiding this comment.
same here, please extract to a method
| target_pool = StoragePool.list(self.apiclient, name=target_name)[0] | ||
| voldata = volume.list(self.apiclient, id=volume.id) | ||
|
|
||
| # Move our volume to the source datastore |
Member
Author
There was a problem hiding this comment.
having this comment indicates that we should have a method call here i.e. move_source_volume_to_source_datastore()
and then move the block below to a
def move_source_volume_to_source_datastore(...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
internal as it is not even draft yet. but opening to be able to discuss and extend
todo
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?